Turn page while playing #1383
Open
Turn page while playing #1383
+47
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to allow the navigation with the Volume buttons even when audiobooks are playing.
RaHoni
force-pushed
the
turn_page_while_playing
branch
from
34e9225 to
12a3969
Compare
|
@fawazral would you want to test this PR? |
|
@RaHoni I just tested it out and it works as intended! Thanks so much for doing this! |
…ngs to use the same LabelOn and LabelOff translations
|
I didn't catch this before but I think we can use the same "On" and "Off" translation for the settings. If it turns out there are some languages that need them separated for whatever reason we can do that, but if we can re-use translation strings we should. I updated the label for the new ereader setting to be more clear so you'll have to translate that again in German |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1365. This adds an additional settings that disables the check for playing when enabled.
The default for this setting is off.
But since while testing i noticed that the problem for #1374 was also showing up on the Virtual Pixel 7a. The simple fix was removing the half-screen option. @advplyr this does change the Settings to be full-screen. Is this okay or is there something else I should do?